Open
Conversation
Member
|
I'm not sure that this really makes it more clear. what code were you putting where? |
Author
|
Based on how I read it I was trying many variations of: ...because the line that I have now moved down seemed to suggest that the function was supposed to be above (i.e. in the place where the comment was) |
Member
|
what do you think you would have done if there had been no comment, return function (read) {
read(null, ...)
})you must have gotten lots of errors about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move //your pull-stream reader... down a line to make it more clear
...when I did this exercise I spent a bunch of time trying to figure why the code I thought should be inside the read function was supposed to be before it but not working, until I said fuck it and put it where I thought it should go and then it just worked.